Dmitriy_Vaschenko by dvaschenko · Pull Request #47 · NikolaevArtem/Java_Core_June_2021

dvaschenko · 2021-07-12T17:07:22Z

No description provided.

README.md

src/main/java/homework/task1/Task1.java

…eature/DmitriyVaschenko

# Conflicts: # README.md

src/main/java/homework/task1/Task1.java

…eature/DmitriyVaschenko

src/main/java/homework/task1/ConsolePrinter.java

NikolaevArtem · 2021-09-02T13:10:44Z

src/main/java/homework_2/pyramid_printer/PyramidPrinter.java

+import java.io.IOException;
+import java.io.InputStreamReader;
+
+public class PyramidPrinter {


Same for -1 and 5.4

isValid method fixed

src/main/java/homework_2/random_chars_table/RandomCharsTable.java

NikolaevArtem · 2021-09-02T13:15:23Z

src/main/java/homework_1/ConsolePrinter.java

+            for (int i = 0; i < args.length; i++) {
+
+                String toPrint = args[i];
+                if (toPrint.equalsIgnoreCase("error")) {                                //checking for error


Opt: I think this part is self-explanatory

NikolaevArtem · 2021-09-02T13:16:44Z

src/main/java/homework_2/random_chars_table/RandomCharsTable.java

+import java.util.Locale;
+
+public class RandomCharsTable {
+    private final String ERR_MSG = "Passed parameters should match the format [positive integer] [positive integer] [even|odd]";


Opt: could be static

NikolaevArtem · 2021-09-02T13:17:42Z

src/main/java/homework_2/random_chars_table/RandomCharsTable.java

+        try (BufferedReader reader = new BufferedReader(new InputStreamReader(System.in))) {
+
+            String rawInput = reader.readLine();
+            result = rawInput.split(" ");


Suggested change

result = rawInput.split(" ");

return rawInput.split(" ");

Here and in other places

NikolaevArtem · 2021-09-02T13:18:26Z

src/main/java/homework_2/random_chars_table/RandomCharsTable.java

+        String lenStr;
+        String widStr;
+        String method;


Opt: this way of initialization is rarely used in Java

change to single line init

ArtemNikolaev1 · 2021-09-27T11:48:51Z

src/main/java/course_project/Main.java

+import course_project.Utils.ConsoleHandling.Printer;
+import course_project.components.Field;
+
+public class Main {


The computer shot it shown only on the next computer turn

Opt: cells around a destroyed ship could be marked as miss automatically

Well-done! The game is confortable to play, has nice interface, automatic ship placement, informative messages. The visual representation is also good.

From the code perspective also looks good, there are minor issues but in general, the code is readable, easy to follow, has nice abstractions. You show good knowledge of Java Core and Java libraries. Approved!

ArtemNikolaev1 · 2021-09-27T11:52:33Z

src/main/java/course_project/Utils/ConsoleHandling/Printer.java

+    public void printYouWasHit() {
+        String YOU_WAS_HIT = "Uh, oh, your ship is falling apart!";
+        System.out.println(YOU_WAS_HIT);
+    }


Opt: methdos like that are not needed, instead you should introduce static constants and just call sout(constant) where needed

ArtemNikolaev1 · 2021-09-27T11:53:58Z

src/main/java/course_project/Utils/ShipPlacers/Placer.java

+import java.util.ArrayList;
+import java.util.List;
+
+public interface Placer {


Opt: it has a lot of logic, so it's more like an abstract class

Although you can use default in interfaces, it's not recommended

dvaschenko and others added 4 commits July 6, 2021 21:53

Task 1 and project

fc198c5

Correct solution

766bfbe

Create README.md

53d43e9

Update README.md

a2d59f3

dvaschenko added the readyForReview Sign for Artem to take a look label Jul 12, 2021

dvaschenko changed the title ~~Feature/dmitriy vaschenko~~ Dmitriy_Vaschenko Jul 12, 2021

NikolaevArtem reviewed Jul 13, 2021

View reviewed changes

README.md Show resolved Hide resolved

NikolaevArtem reviewed Jul 13, 2021

View reviewed changes

src/main/java/homework/task1/Task1.java Outdated Show resolved Hide resolved

NikolaevArtem reviewed Jul 13, 2021

View reviewed changes

src/main/java/homework/task1/Task1.java Outdated Show resolved Hide resolved

NikolaevArtem added bug Code fix needed and removed readyForReview Sign for Artem to take a look labels Jul 13, 2021

dvaschenko added 2 commits July 13, 2021 22:52

Red added, System.exit removed.

5413036

Merge remote-tracking branch 'origin/feature/DmitriyVaschenko' into f…

0a4894d

…eature/DmitriyVaschenko

dvaschenko added the readyForReview Sign for Artem to take a look label Jul 13, 2021

dvaschenko and others added 4 commits July 14, 2021 21:00

HW 2.1 first attempt

7a1e360

Some package and readme changes

1f1bf78

HW 2 task 2

2a866b0

Merge branch 'master' into feature/DmitriyVaschenko

21cb740

# Conflicts: # README.md

NikolaevArtem reviewed Jul 15, 2021

View reviewed changes

src/main/java/homework/task1/Task1.java Outdated Show resolved Hide resolved

NikolaevArtem reviewed Jul 15, 2021

View reviewed changes

src/main/java/homework/task1/Task1.java Outdated Show resolved Hide resolved

NikolaevArtem reviewed Jul 15, 2021

View reviewed changes

src/main/java/homework/task1/Task1.java Outdated Show resolved Hide resolved

NikolaevArtem reviewed Jul 15, 2021

View reviewed changes

src/main/java/homework/task1/Task1.java Outdated Show resolved Hide resolved

NikolaevArtem removed the readyForReview Sign for Artem to take a look label Jul 15, 2021

dvaschenko added 3 commits July 18, 2021 23:30

HW 2 done tasks and HW 1 fixed.

460d1ef

Merge remote-tracking branch 'origin/feature/DmitriyVaschenko' into f…

d94f469

…eature/DmitriyVaschenko

fixed output

dec261f

dvaschenko added the readyForReview Sign for Artem to take a look label Jul 18, 2021

NikolaevArtem reviewed Jul 19, 2021

View reviewed changes

src/main/java/homework/task1/ConsolePrinter.java Outdated Show resolved Hide resolved

NikolaevArtem added HW_1 Good to go and removed bug Code fix needed labels Jul 19, 2021

README revisions

eae2a8a

NikolaevArtem reviewed Sep 2, 2021

View reviewed changes

src/main/java/homework_2/random_chars_table/RandomCharsTable.java Show resolved Hide resolved

NikolaevArtem reviewed Sep 2, 2021

View reviewed changes

NikolaevArtem removed the readyForReview Sign for Artem to take a look label Sep 2, 2021

small fixes

04089a0

dvaschenko added the readyForReview Sign for Artem to take a look label Sep 5, 2021

dvaschenko added 8 commits September 23, 2021 17:51

Project is in process

3e9e559

nano fix

7009de9

90 % done, wo tests

651039a

Functional is done, tests to do

9f8e8d9

HW 3 revisited ,6,7 added

0bb6477

Some tests added

ceef6d1

Some more tests added

5d7c2c7

Workable main

edf0cc0

ArtemNikolaev1 reviewed Sep 27, 2021

View reviewed changes

NikolaevArtem added Course Project HW_2 HW_3 HW_4 HW_5 HW_6 HW_7 and removed bug Code fix needed readyForReview Sign for Artem to take a look labels Sep 27, 2021

Conversation

dvaschenko commented Jul 12, 2021

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants